Add middleware for x-forwarded-proto header#13
Open
lukaszkorecki wants to merge 1 commit intoring-clojure:masterfrom
Open
Add middleware for x-forwarded-proto header#13lukaszkorecki wants to merge 1 commit intoring-clojure:masterfrom
lukaszkorecki wants to merge 1 commit intoring-clojure:masterfrom
Conversation
weavejester
requested changes
Apr 4, 2026
Member
weavejester
left a comment
weavejester
left a comment
There was a problem hiding this comment.
Thanks for the commit. There's some minor formatting/style changes that I've added as inline comments. Can you also change the commit message to:
Add middleware for x-forwarded-proto header
This ensures the PR adheres to the contributing guidelines.
weavejester
reviewed
Apr 4, 2026
Author
|
Happy to help - I'll pick this up on Monday and apply all suggestions. I assume you prefer this PR be a squashed commit, right? |
Member
|
Yep; this seems a simple enough addition that only one commit is required. |
lukaszkorecki
changed the title
Author
|
@weavejester updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows existing pattern for
x-forwarded-forheader support - whenx-forwarded-protois detected and contains one of allowed values, it will override:schemekey in the request map.